openedx / edx-platform

The Open edX LMS & Studio, powering education sites around the world!
https://openedx.org
GNU Affero General Public License v3.0
7.1k stars 3.79k forks source link

Fix edx-platform required checks #34789

Open kdmccormick opened 3 months ago

kdmccormick commented 3 months ago

Repository

axim-engineering

Urgency

Low (2 weeks)

Requested Change

The set of required checks on edx-platform and/or the "unit tests successful" check itself need to be fixed, although we're not exactly sure how yet.

They don't currently enforce that all unit tests pass, as the Unit tests successful check seems to be getting skipped.

More details:

We have disabled Auto-merge on edx-platform because of this. As part of resolving this ticket, please re-enable it.

Reasoning

.

openedx-workflow-automation[bot] commented 3 months ago

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

sarina commented 3 months ago

@kdmccormick @e0d are either of you taking this, or is this a backlog eng item?

kdmccormick commented 3 months ago

I am not, and I doubt Ed is, so it's in the backlog, although I'd vouch for it to be high up in the backlog.

sarina commented 3 months ago

I'm just wondering if it's an on-call ticket or not. I don't know how to address this.

kdmccormick commented 3 months ago

Fair, I guess it's more edx-platform maintenance than on-call work.

@feanil and I are next up in the on-call queue, so I figure whichever one of us has time first can pick it up.

kdmccormick commented 2 months ago

@feanil LMK here when you switch us over to github hosted unit test runners. I think it should make these required checks much easier to manage. I'm reeealllllyyyy looking forward to being able to auto-merge edx-platform PRs again 😄

kdmccormick commented 1 month ago

Now that we run all tests on the same infra (GH-hosted runners), this issue is much more tractable.

@feanil ready for your review: https://github.com/openedx/edx-platform/pull/34903

kdmccormick commented 1 month ago

Remaining tasks: