search

openedx / edx-platform

The Open edX LMS & Studio, powering education sites around the world!
https://openedx.org
GNU Affero General Public License v3.0
7.11k stars 3.8k forks source link

test: always run aggregate unit test check #34903

Closed kdmccormick closed 1 month ago

kdmccormick commented 1 month ago

When a shard of unit-tests.yml fails, we want the success job to bemaked "Failed" (not "Skipped"). That's because "Failed" blocks the PR from merging, whereas "Skipped" does not. This change ensures thatsuccess always runs to completion rather than being cancelled as soon as a unit test shard fails or is cancelled.

From https://github.com/marketplace/actions/alls-green#options:

Important: For this to work properly, it is a must to have the job always run, otherwise GitHub will make it skipped when any of the dependencies fail. In some contexts, skipped is interpreted as success which may lead to undersired, unobvious and even dangerous (as in security breach "dangerous") side-effects.

Closes https://github.com/openedx/edx-platform/issues/34789

edx-pipeline-bot commented 1 month ago

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot commented 1 month ago

2U Release Notice: This PR has been deployed to the edX production environment.