search

openedx / edx-platform

The Open edX LMS & Studio, powering education sites around the world!
https://openedx.org
GNU Affero General Public License v3.0
7.36k stars 3.85k forks source link

Bumping edx-enterprise version to 4.19.8 #34912

Closed MueezKhan246 closed 4 months ago

MueezKhan246 commented 4 months ago

Description: Bumping the changes to deploy the changes for this https://github.com/openedx/edx-enterprise/pull/2118.

JIRA: https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-8010

macdiesel commented 4 months ago

I have double checked Alex's work here and I agree with his assessment. If this PR goes out as it is currently written the APIs and callers against this model will begin to fail. PR should be split in to 2 steps.

MueezKhan246 commented 4 months ago

I'm worried that this will cause errors during deployment, the underlying edx-enterprise PR drops columns in the same commit in which it remove model fields. Typically we'd break that up into two steps:

  1. PR just to remove the model fields.
  2. PR to add migration to drop the table columns. https://openedx.atlassian.net/wiki/spaces/AC/pages/23003228/Everything+About+Database+Migrations#EverythingAboutDatabaseMigrations-Howtodropacolumn

I have double checked Alex's work here and I agree with his assessment. If this PR goes out as it is currently written the APIs and callers against this model will begin to fail. PR should be split in to 2 steps.

@iloveagent57 @macdiesel i will be dividing the changes in 3 separate releases (as by default null=False, https://openedx.atlassian.net/wiki/spaces/AC/pages/23003228/Everything+About+Database+Migrations#EverythingAboutDatabaseMigrations-Howtodropacolumn), thanks for the guidance.