Closed Asespinel closed 3 months ago
Thanks for the pull request, @Asespinel! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@mariajgrimaldi When you have the time could you review this PR?
Hi @Asespinel,
I have check the code and I think it's okay, but I think we could re factorize it and make it clean with some auxiliary functions.
Remind that if you need to set a lot of "code comments" could be a signal of your code it is not clear enough.
We could use some auxiliary functions to get the user id, the current time, set the localstorage, and validate if we should show or hide the banner.
Thanks for the suggested changes @Alec4r. I think this PR is ready to be reviewed. Can you check it when you have the chance @felipemontoya @mariajgrimaldi @ormsbee ?
I was going to review this but you folks have it covered. Thanks!
@Asespinel 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.
2U Release Notice: This PR has been deployed to the edX production environment.
2U Release Notice: This PR has been deployed to the edX production environment.
Description
This PR adds a basic functionality to automatically hide the survey report banner when the dismiss button is clicked for one month depending on the user that clicked on the button. This could be changed in the future if requested. We use the localStorage to check when the Dismiss button was clicked so we can hide the banner from the admin site.
Testing instructions