Closed MushtaqRossier closed 1 month ago
Hi @MushtaqRossier , all PRs to openedx repositories need to have gone through review. Even for small PRs, this helps us avoid mistakes and hold each other accountable to best practices. Please have someone review your code before merging next time.
Hi Kyle,
My apologies, noted for next time.
Thank you.
On Wed, Jun 5, 2024 at 4:23 PM Kyle McCormick @.***> wrote:
Hi @MushtaqRossier https://github.com/MushtaqRossier , all PRs to openedx repositories need to have gone through review. Even for small PRs, this helps us avoid mistakes and hold each other accountable to best practices. Please have someone review your code before merging next time.
— Reply to this email directly, view it on GitHub https://github.com/openedx/edx-platform/pull/34917#issuecomment-2150154514, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOUV36PI5ZBKXWPY7JBOY5DZF4NNNAVCNFSM6AAAAABI2I5ZXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQGE2TINJRGQ . You are receiving this because you were mentioned.Message ID: @.***>
--
Mushtaq Rossier Junior Software Engineer Deneb House, 368 Browning Rd, Woodstock, Cape Town, 7925 Office: 0214477565 Cell: 0763565355 @.** https://bit.ly/31YJPg1 | @edxonline https://bit.ly/3cnlmDa | @Lifeat2U https://bit.ly/3cda0BJ | #NoBackRow https://bit.ly/3iBmIO3 Unlock your potential at edX.org https://edx.org/ and 2u.com/careers/. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system.
No problem, thanks @MushtaqRossier .
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.
2U Release Notice: This PR has been deployed to the edX production environment.
Description: Added extra info logs to refundable() method in course_enrollment.py
JIRA: SONIC-521