openedx-webhooks
commented
4 months ago Thanks for the pull request, @GlugovGrGlib!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Update the status of your PR
Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
- Overview of Review Process for Community Contributions
- Pull Request Status Guide
- Making changes to your pull request
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
mphilbrick211
Description
In this PR a new view is added to CMS to render xblock modal views such as editor for advanced problem types and move xBlock modal. It's intended to use this view to render mentioned earlier interfaces in the course-authoring MFE. The course-authoring implementation can be found in this PR - https://github.com/openedx/frontend-app-course-authoring/pull/985. This particular decision was made because the functionality to edit and move modals depends on the BackboneJS implementation, and can't be recreated in the React.js within the current solution.
According to discussions in https://github.com/openedx/edx-platform/pull/34161#issuecomment-2112522240 and https://github.com/openedx/frontend-app-course-authoring/pull/964#pullrequestreview-2033590615 the final decision for rendering xblock previews will also affect rendering of the edit modal for advanced xBlock. Therefore, it was decided to postpone the merge of the current implementation, and revise it after the decision for xBlocks previews is made.
Supporting information
Issue: https://github.com/openedx/platform-roadmap/issues/321
Testing instructions
Start CMS service
Copy xBlock locator for advanced problem
Open to - {CMS_BASE}/xblock/{xblock_locator}/actions/edit
See edit modal for the xBlock
Start CMS service
Copy xBlock locator for advanced problem
Open to - {CMS_BASE}/xblock/{xblock_locator}/actions/move
See move modal for the xBlock
Deadline
"None"
Other information
This PR is a replacement for the github.com/openedx/edx-platform/pull/34656