openedx / edx-platform

The Open edX LMS & Studio, powering education sites around the world!
https://openedx.org
GNU Affero General Public License v3.0
7.09k stars 3.79k forks source link

Fix flaky TestGetCourseUserPartitions tests #35028

Open robrap opened 1 week ago

robrap commented 1 week ago

Following the old Flaky Test Process, I've deleted two flaky tests.

The deletion PR is https://github.com/openedx/edx-platform/pull/35029.

The following tests were deleted:

Notes/Questions:

Failure 1:

=========================== short test summary info ============================
FAILED xmodule/partitions/tests/test_partitions.py::TestGetCourseUserPartitions::test_enrollment_track_partition_not_added_if_conflict - AssertionError: assert 1 == 2
 +  where 2 = len([UserPartition(id=0, name='Mock Partition', description='for testing purposes', groups=[Group(id=0, name='Group 1'), G...serPartitionScheme object at 0x7f3198774dd0>, parameters={'course_id': 'course-v1:org_0+course_0+run_0'}, active=True)])
==== 1 failed, 1487 passed, 170 skipped, 1572 warnings in 229.69s (0:03:49) ====

Failure 2:

=========================== short test summary info ============================
FAILED xmodule/partitions/tests/test_partitions.py::TestGetCourseUserPartitions::test_enrollment_track_partition_not_added_if_disabled - AssertionError: assert 1 == 2
 +  where 2 = len([UserPartition(id=0, name='Mock Partition', description='for testing purposes', groups=[Group(id=0, name='Group 1'), G...serPartitionScheme object at 0x7f6d54d9e9d0>, parameters={'course_id': 'course-v1:org_0+course_0+run_0'}, active=True)])
==== 1 failed, 1487 passed, 170 skipped, 1572 warnings in 229.98s (0:03:49) ====
robrap commented 1 week ago

FYI: @mariajgrimaldi @kdmccormick

mariajgrimaldi commented 1 week ago

Hi, @robrap! Thanks for letting us know. I'll try to review what happened this week.

robrap commented 1 week ago

@mariajgrimaldi: I'm only guessing it is your PR because I didn't see any other changes, but I want to confirm it is just a guess.