openedx / edx-platform

The Open edX LMS & Studio, powering education sites around the world!
https://openedx.org
GNU Affero General Public License v3.0
7.41k stars 3.87k forks source link

Don't allow error pages to raise errors #35216

Open timmc-edx opened 2 months ago

timmc-edx commented 2 months ago

The generic error views for 403, 404, and 500 can themselves raise exceptions, resulting in users not having intelligible error pages and making it harder for service operators to understand what is happening.

See https://github.com/openedx/edx-platform/issues/35151 for some past fallout of these problems. Note in particular that bad translations can cause error pages to raise exceptions at any time.

Acceptance criteria:

robrap commented 2 months ago

Do we know if this affects other IDAs (public or private) and the cookiecutter used to create IDAs? Something to consider.