openedx / edx-platform

The Open edX LMS & Studio, powering education sites around the world!
https://openedx.org
GNU Affero General Public License v3.0
7.47k stars 3.89k forks source link

[DEPR]: Remove waffle flag ENABLE_GLOBAL_STAFF_OPTIMIZATION #35649

Open pdpinch opened 1 month ago

pdpinch commented 1 month ago

Proposal Date

2024-10-15

Target Ticket Acceptance Date

2024-10-31

Earliest Open edX Named Release Without This Functionality

Teak - 2025-04

Rationale

This waffle flag enables an optimization in the legacy Studio course list view that more efficiently loaded a very long list of courses. Typically, this only made a difference on deployments where users were staff on a very large number of courses, for example edx.org.

The flag does not function in the new studio (aka course authoring) MFE. In that context, loading a large list of courses is optimized by default.

Removal

We don't plan to test this flag in the Sumac release, since it would require reverting to the legacy studio interface.

After Sumac, the code for the flag can be removed. A naive search for the flag turns up just 4 locations, including 2 tests.

Replacement

The functionality has already been replaced in the current APIs used with the Studio MFE.

Deprecation

No response

Migration

No response

Additional Info

No response

Task List

No response

jristau1984 commented 1 month ago

Already discussed in T&L: https://twou.slack.com/archives/C04BHDFQMDK/p1729090844945349

pdpinch commented 1 month ago

I don't think I have access to twou.slack.com links. What was the outcome of the discussion?