Closed ChrisChV closed 4 days ago
Thanks for the pull request, @ChrisChV!
Please work through the following steps to get your changes ready for engineering review:
If you haven't already, check this list to see if your contribution needs to go through the product review process.
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
This PR must be merged before / after / at the same time as ...
This PR is waiting for OEP-1234 to be accepted.
This PR must be merged by XX date because ...
This is for a course on edx.org.
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
This repository is currently maintained by @openedx/wg-maintenance-edx-platform
. Tag them in a comment and let them know that your changes are ready for review.
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
CC @farhaanbukhsh
Hmm, seems like we have several different issues caused by bumping the openedx-learning version without backporting other changes. I was kind of worried this would happen. Though I'm not really sure why common_constraints.txt
is changing. Is that happening on sumac.master
too?
CC @ormsbee
Though I'm not really sure why common_constraints.txt is changing. Is that happening on sumac.master too?
Yes, common_constraints.txt
changes when compiling the requirements. The solution would be to backport this common_constraints.txt
change or a backport of this https://github.com/openedx/edx-platform/commit/040ff12430d2418f8bea0c7ec8d2eeb0f734a8e7
Oh I see now that the only changes are to commented out lines, so it's totally fine to just include those common_constraints.txt
changes in this PR. I'm not sure the best way to solve the other static analysis issue though; I suspect you'll also need to bring in d19707793bacb44c9493844844f21ba3ca499e0e
Looks good. Is there an easy way for me to test this? (without interrupting my master
devstack)
OK, I got my Sumac devstack working and tested this out. Nice work :)
FYI on this backport, @farhaanbukhsh
Fixed component counter synchronization and adds a published > num_counts field in collections in the search index.
Cherry-picked from these commits:
Backport of https://github.com/openedx/edx-platform/pull/35734