search

openedx / edx-platform

The Open edX LMS & Studio, powering education sites around the world!
https://openedx.org
GNU Affero General Public License v3.0
7.36k stars 3.85k forks source link

Theme mechanism doesn't work with i18n extraction #434

Closed hanwentao closed 10 years ago

hanwentao commented 11 years ago

The current theme mechanism puts theme-related files in themes/ directory which is in the same parent directory as edx-platform. Pybabel cannot extract strings from directories outside edx-platform.

natehardison commented 11 years ago

Would it be able to extract files from apps placed in INSTALLED_APPS? One conversation we've had is about making the theme an app.

On Thursday, July 18, 2013, Wentao Han wrote:

The current theme mechanism puts theme-related files in themes/ directory which is in the same parent directory as edx-platform. Pybabel cannot extract strings from directories outside edx-platform.

— Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/issues/434 .

Nate

hanwentao commented 11 years ago

Where is INSTALLED_APPS? It's OK if it is under edx-platform/.

natehardison commented 11 years ago

Hmm, that's not necessarily the case. INSTALLED_APPS is a list of Python paths to Python packages that are on PYTHON_PATH, which isn't just edx-platform. See https://docs.djangoproject.com/en/dev/ref/settings/#installed-apps for more.

And I don't totally understand the issue here. We can still use the current internationalization functions in our theme templates. Is the extraction just an automated process to make internationalization easier?

Nate

On Thu, Jul 18, 2013 at 8:29 PM, Wentao Han notifications@github.comwrote:

Where is INSTALLED_APPS? It's OK if it is under edx-platform/.

— Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/issues/434#issuecomment-21229647 .

hanwentao commented 11 years ago

Yes. But the i18n extraction tool edx-platform/i18n/extract.py only works on files under edx-platform/ no matter how I changed edx-platform/conf/locale/babel.cfg.

singingwolfboy commented 10 years ago

I'm closing this issue for now. We're turning off Github Issues, because there are too many different places that people can go to ask for help. By reducing the number of places to ask for help, we're making it easier for knowledgable people to find people to help, so that everyone can help each other more effectively. If you still need help, try asking on our mailing lists or creating an issue on our public JIRA issue tracker.