search

openedx / edx-toggles

Library and utilities for feature toggles
https://edx-toggles.readthedocs.io/en/latest/
GNU Affero General Public License v3.0
5 stars 10 forks source link

Possible issue with edx-platform toggle report #310

Closed robrap closed 8 months ago

robrap commented 1 year ago

At edx.org, we saw several discrepancies between our private settings (edx-internal) and the toggles reported in https://courses.edx.org/api/toggles/v0/state/.

As an example, the setting ENABLE_DEMOGRAPHICS_COLLECTION is set in edx-internals, and yet did not appear in the report. Additionally, another toggle that was being rolled out in Stage did not appear in the report. Note that the two examples seen were top-level toggles (i.e. were not a part of a dict).

It has not been confirmed that these settings appear on the actual boxes, in which case the report may be fine and there might be some other issue in deploying settings. However, if the settings are found on the box, it may be that there is a problem generating the report itself.

robrap commented 1 year ago

@rgraber: Are you able to get on to Stage boxes to confirm, or would SRE need to be involved? (Note: this has not been prioritized, but it was disconcerting when I was trying to rely on this report for deployment.)

robrap commented 8 months ago

I found the issue and am fixing it in this PR: https://github.com/openedx/edx-toggles/pull/337