openedx / event-bus-kafka

Kafka implementation for Open edX event bus
GNU Affero General Public License v3.0
5 stars 5 forks source link

feat: make use of abstract consumer API #154

Closed navinkarkera closed 1 year ago

navinkarkera commented 1 year ago

Dependencies

Merge checklist: Check off if complete or not applicable:

openedx-webhooks commented 1 year ago

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

e0d commented 1 year ago

@navinkarkera Looks like this branch need a rebase, let me know when you are able to do that and push the changes.

e0d commented 1 year ago

I suspect that the codecov issues will be solved by the rebase.

navinkarkera commented 1 year ago

@e0d Thanks! Rebased.

timmc-edx commented 1 year ago

Would you be comfortable updating docs/how_tos/manual_testing.rst as well as part of this PR? If not, I can ticket that up for us to do as a followup. (I'm not sure if you've worked with Kafka in devstack.)

navinkarkera commented 1 year ago

I have worked with Kafka in devstack, so I can update the docs. Will do it tomorrow and let you know.

On Thu, 4 May, 2023, 11:11 pm Tim McCormack, @.***> wrote:

Would you be comfortable updating docs/how_tos/manual_testing.rst as well as part of this PR? If not, I can ticket that up for us to do as a followup. (I'm not sure if you've worked with Kafka in devstack.)

— Reply to this email directly, view it on GitHub https://github.com/openedx/event-bus-kafka/pull/154#issuecomment-1535164868, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTDWEYYF76R2BHFYOY34ZLXEPS5NANCNFSM6AAAAAAXL7VNKI . You are receiving this because you were assigned.Message ID: @.***>

navinkarkera commented 1 year ago

@timmc-edx Updated manual testing document. Please let me know if it looks good.

e0d commented 1 year ago

@navinkarkera looks like there are conflicts on the branch, can you have a look?

timmc-edx commented 1 year ago

Other than the conflicts (probably changelog and version) everything is looking good!

navinkarkera commented 1 year ago

@e0d @timmc-edx Resolved conflicts and updated date in changelog.

openedx-webhooks commented 1 year ago

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.