openedx / event-routing-backends

Consume edx tracking events and transform/transmit them to other LRSs.
GNU Affero General Public License v3.0
9 stars 17 forks source link

Some tests have no expected fixture #321

Open bmtcril opened 1 year ago

bmtcril commented 1 year ago

The following test cases aren't actually being run due to "expected" fixtures not existing for them. I'm not sure how this impacts our test coverage, but I wanted to call it out so if someone else runs into this they know what's up. I feel like we talked about this a while ago @ziafazal , but I don't remember what the deal was.

ziafazal commented 1 year ago

@bmtcril there are multiple reason for not having "expected" fixtures in these cases

  1. We don't need a expected fixture in some cases like when we test certain attributes to be present in event and just one expected fixture either Caliper or xAPI is enough and we opted to have just xAPI expected fixture .e.g
  1. In some cases we don't have relevant events in Caliper specification e.g
  1. We have not written Caliper transformers for some events yet e.g.
bmtcril commented 1 year ago

Thanks Zia, that makes sense. I'm going to put forward a suggestion that we annotate the tests that we're skipping to explain why and make sure we don't just accidentally miss some due to folks not knowing they need to make them for parts of the codebase they're not currently working in (ex. not writing the expected Caliper test when focused on xAPI).