openedx / event-routing-backends

Consume edx tracking events and transform/transmit them to other LRSs.
GNU Affero General Public License v3.0
9 stars 17 forks source link

Allow event-routing-backends to be used when transforming non-openedx events #431

Closed pomegranited closed 2 months ago

pomegranited commented 3 months ago

Description:

Event Routing Backends is designed to be installed with edx-platform, and the code assumes this. But we want to use ERB outside of the platform too -- it contains event transform classes and test logic which is useful when transforming non-openedx events.

This PR:

See https://github.com/open-craft/openedx-completion-aggregator/pull/205 for an example usage.

JIRA: FAL-3766 (private-ref)

Part of https://github.com/openedx/openedx-aspects/issues/222

Merge deadline: end of June

Testing instructions:

See https://github.com/open-craft/openedx-completion-aggregator/pull/205 for manual test instructions.

Merge checklist:

Post merge:

openedx-webhooks commented 3 months ago

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

pomegranited commented 2 months ago

Thank you for your review @Ian2012 !

@bmtcril or @ziafazal is there anything else I need to fix here before this can be merged?

openedx-webhooks commented 2 months ago

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.