openedx / frontend-app-account

Open edX micro-frontend application for managing user account information.
GNU Affero General Public License v3.0
17 stars 122 forks source link

fix: long email field on account page #1025

Open bydawen opened 5 months ago

bydawen commented 5 months ago

Similar PR is opened to the master branch: https://github.com/openedx/frontend-app-account/pull/1024

Fix for the long email field to prevent page break for the mobile view:

If user has a long type email it will be overlap from content of page:

1 11

After fix:

2 22
openedx-webhooks commented 5 months ago

Thanks for the pull request, @bydawen!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/edx-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (open-release/quince.master@1fcb762). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/quince.master #1025 +/- ## ============================================================= Coverage ? 46.61% ============================================================= Files ? 116 Lines ? 2407 Branches ? 640 ============================================================= Hits ? 1122 Misses ? 1211 Partials ? 74 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.