search

openedx / frontend-app-account

Open edX micro-frontend application for managing user account information.
GNU Affero General Public License v3.0
17 stars 121 forks source link

feat: use frontend-plugin-framework to provide a FooterSlot #1044

Closed brian-smith-tcril closed 3 months ago

brian-smith-tcril commented 4 months ago

This adds a plugin slot to provide a way to replace the footer using frontend-plugin-framework.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.70%. Comparing base (9693d93) to head (9c5dfae). Report is 14 commits behind head on master.

:exclamation: Current head 9c5dfae differs from pull request most recent head 1fa9791. Consider uploading reports for the commit 1fa9791 to get more accurate results

Files Patch % Lines
src/plugin-slots/FooterSlot/index.jsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1044 +/- ## ========================================== + Coverage 56.55% 56.70% +0.14% ========================================== Files 117 120 +3 Lines 2456 2499 +43 Branches 654 673 +19 ========================================== + Hits 1389 1417 +28 - Misses 996 1008 +12 - Partials 71 74 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arbrandes commented 3 months ago

We missed the Redwood cutoff but exactly 60 seconds. 🤷🏼‍♂️