openedx / frontend-app-account

Open edX micro-frontend application for managing user account information.
GNU Affero General Public License v3.0
18 stars 123 forks source link

fix: send json accept headers for POST requests #1145

Closed mariajgrimaldi closed 1 week ago

mariajgrimaldi commented 1 week ago

Description

This PR solves a CORS error when calling the endpoints for Changing Site Language and Unlinking the SSO Account. To resolve this error we simply specify the Accept: 'application/json' header in the request.

These are the related issues:

https://github.com/openedx/frontend-app-account/issues/1052 https://github.com/openedx/wg-build-test-release/issues/376

1139 backport

openedx-webhooks commented 1 week ago

Thanks for the pull request, @mariajgrimaldi!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/edx-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.