Closed ChrisChV closed 2 weeks ago
@ChrisChV This will be part of another epic (3, not 1). Epic 3 will be building various sidebars. The only sidebar we'll build in epic 1 is the "Library Info Sidebar" to rename the library.
This will be part of another epic (3, not 1). Epic 3 will be building various sidebars. The only sidebar we'll build in epic 1 is the "Library Info Sidebar" to rename the library.
@bradenmacdonald Ok. So https://github.com/openedx/frontend-app-course-authoring/issues/1042 is not part of the epic 1?
@ChrisChV At the moment it's not part of the epic, but we may add it back in.
@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox!
Couple of notes (see screenshot)-
Not in screenshot - It looks like we are showing "More... " in the tab menu when there is still room to fit "Details". I'm also not sure about the need for "More" when there is just one tab in the menu, I think we should always keep it as Details when it is the only tab being cut off, and if needed truncate the word Details. Move to "More.." menu when the breakpoint requires more than 1 tab to be in the "More" menu item drop down. (cc @sdaitzman, lmk if you have any thoughts here)
It looks like we are showing "More... " in the tab menu when there is still room to fit "Details". I'm also not sure about the need for "More" when there is just one tab in the menu, I think we should always keep it as Details when it is the only tab being cut off, and if needed truncate the word Details. Move to "More.." menu when the breakpoint requires more than 1 tab to be in the "More" menu item drop down. (cc @sdaitzman, lmk if you have any thoughts here)
We opened a separate issue for that: https://github.com/openedx/paragon/issues/3200
Hi @lizc577! Sorry for missing your comments!
- When I made the title long, the hover state on the edit icon is getting skewed
I'm fixing it as part of https://github.com/openedx/frontend-app-authoring/pull/1293
- At this breakpoint, the 3 dot menu is falling below the edit/publish buttons, can we make it so that the 3 dot menu is never on its own line?
I didn't find a way to fix this in the current component, but we added a fixed width that prevents this from happening (at least on English)
@jmakowski1123 @lizc577 @sdaitzman @marcotuts The issues mentioned here should be fixed in the sandbox
It looks like another UI bug was introduced with the 3-dot fix - now the expand button overlays on top of the 3-dot menu when it's expanded. I've created a separate bug ticket https://github.com/openedx/frontend-app-authoring/issues/1390
✅ In Scope:
Each tab in the component sidebar contains specific functionality and will be defined in separate stories under Epic 3.