Use current CAPA problem editor in Libraries

openedx / frontend-app-authoring

Front-end for the Open edX Studio experience, implemented in React and Paragon.

GNU Affero General Public License v3.0

13 stars 75 forks source link

Use current CAPA problem editor in Libraries #1091

Closed jmakowski1123 closed 1 week ago

jmakowski1123 commented 4 months ago

"As a Library Author, I expect to have the exact same experience when creating and editing CAPA problems in Libraries as I do in Courses."

Libraries utilize the same problem editor as courses.

The Problem Editor can be accessed from the following places in the UI:

When I click the "new button" and the "add content sidebar" opens and I click on "Problem", then the problem editor modal pops up and I can create a new problem component
In the component card, when I click on the 3-dot menu and then when I click on "edit" in the 3 dot menu, then the problem editor for that component pops up, and I can make edits or adjustments to that problem
In the header of the component sidebar, when I click on the "edit" button, then the problem editor for that component pops up, and I can make edits or adjustments to that problem

bradenmacdonald commented 3 weeks ago

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox. Any "Problem" component should be editable, and you can create new ones.

lizc577 commented 3 weeks ago

@bradenmacdonald Should I be able to save? EDIT: ignore, I was looking at the wrong sandbox

lizc577 commented 3 weeks ago

If you change the number of attempts, it seems to mess up the editor. See video which shows the issue when I change the number of attempts and then how it works perfectly when I do not change the number of attempts

https://github.com/user-attachments/assets/a7b4ae99-11ee-460f-9bd1-ba37befc0210

jmakowski1123 commented 2 weeks ago

Sometimes when I re-open an existing problem to edit it, the editor reverts back to the html editor, even if I created the initial problem using the wysiwyg editor. I cannot figure out a pattern/reason, but here are two examples:

https://app.tagging-preview.staging.do.opencraft.hosting/course-authoring/library/lib:OpenCraft:TL/editor/problem/lb:OpenCraft:TL:problem:e741d5b8-a5ef-481a-a779-2b9ca7786974

https://app.tagging-preview.staging.do.opencraft.hosting/course-authoring/library/lib:OpenCraft:TL/editor/problem/lb:OpenCraft:TL:problem:ca7c1933-ee04-4e88-86e5-270298c7a2d0

The expected behavior should be:

If I create the problem using the wysiwyg editor, then every time the problem is re-opened to be edited, the wysiwyg editor is the default experience.

If I create the problem using the html editor, then every time the problem is re-opened to be edited, the html editor is the default experience.

jmakowski1123 commented 2 weeks ago

The description field for problems has some wonky spacing issues. There's no space between the end of the problem/question and the answers, and there are no spaces between the answers for multiple select problem types.

jmakowski1123 commented 2 weeks ago

Every new problem created has a tag automatically added, or at least the tag icon automatically displays "1". I can't see what the tags are. Is that intentional?

bradenmacdonald commented 2 weeks ago

@jmakowski1123

Every new problem created has a tag automatically added, or at least the tag icon automatically displays "1". I can't see what the tags are. Is that intentional?

That's the automatic tag "Language: English". We'll soon be deploying the tags widget on the sandbox and you'll be able to see it more easily. We can also turn that feature off if it's not helpful.

bradenmacdonald commented 2 weeks ago

Sometimes when I re-open an existing problem to edit it, the editor reverts back to the html editor, even if I created the initial problem using the wysiwyg editor.

It's whenever the "max attempts" is set. I have a fix in review, and will let you know when it's updated and fixed on the sandbox.

The description field for problems has some wonky spacing issues.

I've got a fix for that too, coming soon :)

bradenmacdonald commented 2 weeks ago

@lizc577 @jmakowski1123 All of the issues you reported should now be fixed on the sandbox - please take a look.

jmakowski1123 commented 1 week ago

@jmakowski1123

Every new problem created has a tag automatically added, or at least the tag icon automatically displays "1". I can't see what the tags are. Is that intentional?

That's the automatic tag "Language: English". We'll soon be deploying the tags widget on the sandbox and you'll be able to see it more easily. We can also turn that feature off if it's not helpful.

Yeah, I'd turn the auto tagging for language off for now.

jmakowski1123 commented 1 week ago

Fixes look good!

bradenmacdonald commented 1 week ago

@jmakowski1123

Every new problem created has a tag automatically added, or at least the tag icon automatically displays "1". I can't see what the tags are. Is that intentional?

That's the automatic tag "Language: English". We'll soon be deploying the tags widget on the sandbox and you'll be able to see it more easily. We can also turn that feature off if it's not helpful.

Yeah, I'd turn the auto tagging for language off for now.

OK, I've turned it off on the sandbox (only affects new things going forward). It is already off by default.