openedx / frontend-app-authoring

Front-end for the Open edX Studio experience, implemented in React and Paragon.
GNU Affero General Public License v3.0
13 stars 75 forks source link

Collections Page - Search within a collection #1103

Closed jmakowski1123 closed 1 week ago

jmakowski1123 commented 4 months ago
Screen Shot 2024-07-17 at 3 46 27 PM
pomegranited commented 1 month ago

@jmakowski1123 @bradenmacdonald Sorting Components within a Collection is handled by a separate ticket, so should be excluded from the requirements here: https://github.com/openedx/frontend-app-course-authoring/issues/1166

navinkarkera commented 2 weeks ago

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

bradenmacdonald commented 2 weeks ago

@sdaitzman I asked the same thing on Slack. I think it's blocked on https://github.com/openedx/frontend-app-authoring/issues/1310 . In the meantime you can go to this URL: https://app.tagging-preview.staging.do.opencraft.hosting/course-authoring/library/lib:OpenCraft:TL/collection/studio-advanced/ it has tags and stuff too.

sdaitzman commented 2 weeks ago

Thanks @bradenmacdonald!

jmakowski1123 commented 2 weeks ago

@sdaitzman Do you think it's clear enough to users that once tags have been selected in the filter, they just click anywhere outside of the window to close it?

Screen Shot 2024-09-24 at 3 19 48 PM
jmakowski1123 commented 2 weeks ago

Overall this is great. I love the highlighting feature and how it's responsive to where the word match is in the description, even if the description doesn't fit in the tile preview.

What are the boundaries of the text search? Is it title, description, metadata?

sdaitzman commented 2 weeks ago

@sdaitzman Do you think it's clear enough to users that once tags have been selected in the filter, they just click anywhere outside of the window to close it?

@jmakowski1123 I think it will be clear enough, since other tools work fairly similarly. If we wanted to make things more explicit, we could add an "Apply Filters" button, but I think it's a common pattern to click outside a dropdown like this to close it.

pomegranited commented 2 weeks ago

@jmakowski1123

What are the boundaries of the text search? Is it title, description, metadata?

Keyword search is done across the component display name, block ID, block content, description, tag titles, and collection titles (in that order of priority, same for library components). And any of that is easy to change if needed.