search

openedx / frontend-app-authoring

Front-end for the Open edX Studio experience, implemented in React and Paragon.
GNU Affero General Public License v3.0
13 stars 72 forks source link

Organization search is not working unless page is reloaded with ?org=<ORG> #1110

Open mariajgrimaldi opened 3 months ago

mariajgrimaldi commented 3 months ago

Basically, this flag worked for the legacy Studio Home, improving performance by adding an organization search bar. But as the report mentions, it's not working correctly in the Studio Home MFE. The good thing is that this flag is not needed in the Studio Home MFE since we already have a search bar and pagination, which improves performance for those home pages with lots of courses. I wouldn't consider it a "breaking change" but a known issue for those who want to turn on the Studio Home MFE and are using the flag.

Expected behavior

When the switch is active I can search courses by organization by typing in the Show all courses in organization: search bar.

Actual behavior

However the filter does not work and no courses are displayed with the filter applied or removed.

image

Steps to reproduce

  1. Add and enable the studio_home.enable_global_staff_optimization switch in the LMS Administration Panel.
  2. visit https://hostname/course-authoring/home

Additional info

After clicking Submit to search by organization in the search bar, a queryparam is added to the URL: /course-authoring/home?org=Demo but nothing happens, unless the page is reloaded:

Screencast from 13-06-24 15:44:40.webm

Original issue: https://github.com/openedx/wg-build-test-release/issues/380

mariajgrimaldi commented 3 months ago

@arbrandes @brian-smith-tcril: this raises the question of why we do need an organization search if we already have the general search for the Studio MFE.

I will raise this as a known issue for Redwood so people turn it off because it's not needed in this specific case.