openedx / frontend-app-authoring

Front-end for the Open edX Studio experience, implemented in React and Paragon.
GNU Affero General Public License v3.0
13 stars 75 forks source link

Library Home - Free text search within a Library #1165

Closed jmakowski1123 closed 3 weeks ago

jmakowski1123 commented 3 months ago

a. Title, A-Z b. Title, Z-A c. newest d. oldest e. recently published f. recently modified

Image

bradenmacdonald commented 3 months ago

@jmakowski1123 This is ready for acceptance testing on the sandbox.

jmakowski1123 commented 3 months ago

Couple things:

  1. Is there supposed to be an exit option out of the search dropdown once all of the tags have been selected as part of the search? Currently, I just click outside of the search box and it auto-closes the box. I can't remember what the parallel experience is in the Studio search, and search seems to be down at the moment so I can't readily check it. @ali-hugo do you remember? Either way, it needs to be the same experience in Studio search and in Library search.
Screen Shot 2024-07-29 at 2 51 28 PM
  1. Results don't seem to be responsive when I type in the free-text search field?
Screen Shot 2024-07-29 at 2 52 09 PM
ali-hugo commented 3 months ago

@jmakowski1123

Currently, I just click outside of the search box and it auto-closes the box.

This sounds correct to me. After the user selects tags from the dropdown, the "Tags" button should update accordingly (either with the name of the first tag they selected, or with the name of the first tag and the number of additional tags selected). The selections are saved when the user clicks anywhere outside of the dropdown.

I hope that answers your question.

The sandbox doesn't seem to be running anymore, but I did find this video showing the early stages of the UX. Maybe it will help. You can watch from about halfway:

https://github.com/user-attachments/assets/9ce22918-5867-438d-8e96-c97860aafdb4

jmakowski1123 commented 3 months ago

Thanks @ali-hugo !

jmakowski1123 commented 3 months ago

So @ChrisChV, the outstanding comment on this one is that the free-text typing doesn't produce responsive results. For example, I know that there are two things tagged for "english" here, but when I start typing "english", the results don't show up dynamically

Image

bradenmacdonald commented 3 months ago

@jmakowski1123 The field you're typing in is for finding tags, not for the free-text search. If you type in the free-text search box above, the results are responsive and immediate:

https://github.com/user-attachments/assets/130a0342-da21-4c47-bca8-755cafa5c44c

jmakowski1123 commented 3 months ago

Right, searching for tags. But in Studio search, searching for tags is also responsive, so I think it's good to be consistent and have the same experience in Libraries?

bradenmacdonald commented 3 months ago

@jmakowski1123 It does work exactly the same way. I think it's hard to tell because there's only one tag applied to items in that library. Try using the Studio search in a course and see how the tag text search works, and it's exactly the same in this library view. We can test this again once we're able to edit the tags and apply more tags.

jmakowski1123 commented 2 months ago

Ok, I added the re-testing label.

lizc577 commented 2 months ago

Is it intentional that the recently modified section is not responding to free form text search?

jmakowski1123 commented 1 month ago

Is it intentional that the recently modified section is not responding to free form text search?

@lizc577 I think this point will be rendered mute once the simplified library home page is implemented, right?

jmakowski1123 commented 3 weeks ago

This is working now with the additions of the tagging feature - shifting to done.