openedx / frontend-app-authoring

Front-end for the Open edX Studio experience, implemented in React and Paragon.
GNU Affero General Public License v3.0
13 stars 75 forks source link

Adjustments to tile responsiveness when sidebar is opened #1221

Closed jmakowski1123 closed 3 weeks ago

jmakowski1123 commented 2 months ago

Currently when the sidebar is opened, tiles with long titles and descriptions become very elongated. UI solution?

bradenmacdonald commented 2 months ago

Screenshot 2024-08-26 at 2 04 36 PM

@jmakowski1123 It only affects smaller displays. I think we can address that by switching to three cards per row instead of four? (for small displays)

sdaitzman commented 2 months ago

Rather than setting a fixed number of columns at specific breakpoints and letting the preview text flow across an arbitrary number of lines, I think we should use different fixed constraints (Figma link with examples and comments):

Rather than a fixed number of columns between each breakpoint, this approach limits the card size to ensure all cards are a reasonable size in all dimensions, and allows them to use up more space when it's available.

image

I've left the constraints a bit open-ended here. I'm wondering about feasibility of this sort of approach— let me know if more specific constraints, examples and breakpoints would be helpful. Does something more like this responsive approach seem possible?

bradenmacdonald commented 2 months ago

@sdaitzman Yes, we can do that and I agree it's better than dealing with breakpoints and fixed columns and all that.

CC @rpenido @ChrisChV

rpenido commented 2 months ago

Ack! I will check that tomorrow and post an update here.

rpenido commented 2 months ago

As the other PR was merged, I will create a small task for this next sprint.

sdaitzman commented 2 months ago

Discussed this at libraries relaunch touchpoint today. We decided to (pending evaluating feasibility of scoping these changes to the content libraries studio page only):

Before: image

After: image

bradenmacdonald commented 2 months ago

^ Ideally, we'd add a way that we can enable this "full width mode" for just this one page, and potentially other course authoring MFE pages in the future. If it's too complicated to do, or would affect ALL pages and potentially introduce layout issues on other pages, we can consider postponing it.

rpenido commented 2 months ago

We can parametrize the header only for the library authoring, so I think it is possible to make the change only for this context. Let me know if I should include the header/content size change as part of this issue. CC @bradenmacdonald

bradenmacdonald commented 2 months ago

@rpenido Yes please include it with this issue. Thanks.

rpenido commented 1 month ago

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox.

jmakowski1123 commented 3 weeks ago

This looks ok to my non-UI eyes