search

openedx / frontend-app-authoring

Front-end for the Open edX Studio experience, implemented in React and Paragon.
GNU Affero General Public License v3.0
14 stars 78 forks source link

Which problem configuration fields should be edit-able in a library problem? #1317

Open jmakowski1123 opened 2 months ago

jmakowski1123 commented 2 months ago

When creating a problem in a library, I may not know which course the problem will be used in. Or the problem may be used in multiple courses, each with different grading parameters. Thus, I'd expect that the only configurable fields attached to a problem in a library are the generalized fields that apply to the problem content itself, and not the overall grading schema. Those fields are:

I would not expect to see the following configurable fields attached to a problem in a Library. Instead, I would expect to configure these fields within the course outline, such that my configurations are specific to the grading schema of that particular course:

bradenmacdonald commented 2 months ago

@jmakowski1123 Would you like me to go ahead and disable those fields? And/or display a note that they're not configurable in libraries? Or does this need some more work to figure out the best approach?

kdmccormick commented 2 months ago

(following this since it affects the backend)

bradenmacdonald commented 2 months ago

This will be post-Sumac.

kdmccormick commented 2 months ago

@jmakowski1123 @bradenmacdonald For Sumac, what should happen if I make local edits to a block from a library, and then pull updates from a library? Options are:

  1. Local edits always stay.
  2. Local edits always get blown away.
  3. Certain local edits stay, certain local edits get blown away.
bradenmacdonald commented 2 months ago

@kdmccormick I thought we had an allowlist of fields that make sense to override, like "max attempts", "max score' etc., and anything other than those would get blown away.

kdmccormick commented 2 months ago

@bradenmacdonald Yep, just confirming that we haven't changed on that

kdmccormick commented 2 months ago

In the UI, do we need a way to revert those "customizable" fields to their defaults?

bradenmacdonald commented 2 months ago

@kdmccormick Up to @jmakowski1123 but I'd say it's not necessary for MVP.

jmakowski1123 commented 2 months ago

Nothing in this ticket will be part of the the MVP. Sorry for the confusion.