search

openedx / frontend-app-authoring

Front-end for the Open edX Studio experience, implemented in React and Paragon.
GNU Affero General Public License v3.0
14 stars 77 forks source link

Update workflow for library-sourced content (Authoring MFE - Unit Page) #1464

Open bradenmacdonald opened 3 weeks ago

bradenmacdonald commented 3 weeks ago
  1. When a component in a course is sourced from a v2 library and a newer version is available in the library, display the "Update Available" button. This is already implemented on the legacy Unit page; this task is porting it to the new MFE unit page.

Screenshot

  1. When the button is clicked, display a modal with the <CompareChangesWidget>:

Screenshot

  1. The modal should be large to facilitate previewing the components.
  2. The previews should be interactive (this is already implemented)
  3. The "Accept Changes" and "Ignore Changes" buttons should both work, as they already work in the legacy UI.
  4. Use a Paragon modal for this. It will look different from the legacy UI screenshot seen above.
bradenmacdonald commented 3 weeks ago

@jmakowski1123 FYI

jmakowski1123 commented 2 weeks ago

cc @GlugovGrGlib for visibility. These are small additions being made to the new unit page MFE.

navinkarkera commented 2 weeks ago

@bradenmacdonald Now that the course unit is an iframe that displays the legacy UI, is this issue relevant?

bradenmacdonald commented 2 weeks ago

@navinkarkera Yes, we should be intercepting the events from the iframe and displaying this modal from the Authoring MFE, not from the legacy page. See how they're doing it for the "Move XBlock" modal: https://github.com/openedx/frontend-app-authoring/pull/1422

navinkarkera commented 4 days ago

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

sdaitzman commented 2 days ago

Looks good to me!

image

Similarly to some other areas, the number of concentric boxes is a bit high here, but I don't think it's a blocker for this.

image
navinkarkera commented 1 day ago

@sdaitzman This issue is about displaying the preview changes modal from the new course unit page. You can test it here.

The sandbox is set to take you legacy course unit page by default, but we flip this temporarily if required.

sdaitzman commented 7 hours ago

Thanks @navinkarkera! Tested a few rounds of updates and the ignore changes feature.

Just out of curiosity, what determines whether the legacy/updated course unit page will be shown?

image
bradenmacdonald commented 7 hours ago

@sdaitzman It's a setting that the administrator controls. There is currently no way for users to toggle the setting nor choose for themselves (though that's something I've been pushing for).