search

openedx / frontend-app-authoring

Front-end for the Open edX Studio experience, implemented in React and Paragon.
GNU Affero General Public License v3.0
14 stars 78 forks source link

Bug: Link content toast notification should not be displaying #1489

Open jmakowski1123 opened 3 weeks ago

jmakowski1123 commented 3 weeks ago

The linked content toast notification should not be displaying when I create a new content block, either from library home or from the collection page.

Image

bradenmacdonald commented 3 weeks ago

@navinkarkera The fix for https://github.com/openedx/frontend-app-authoring/issues/1435 seems to have introduced a regression that whenever a component is added to a library (e.g. add a Text component from the Library Home page), it shows a "Content linked successfully" toast. (Even when no collection is involved.)

Can you please look into that? And as mentioned above + on Slack we actually don't ever need that toast so it should be removed everywhere. It wasn't in the original specs for https://github.com/openedx/frontend-app-authoring/issues/1173

CC @rpenido

https://openedx.slack.com/archives/C06JG6RFE4V/p1731022665501119

navinkarkera commented 3 weeks ago

@bradenmacdonald Got it. Created this PR: https://github.com/openedx/frontend-app-authoring/pull/1490 to fix it.

navinkarkera commented 6 days ago

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

sdaitzman commented 4 days ago

I'm not seeing this, so looks good to me... were there any more specific situations that triggered it?

navinkarkera commented 3 days ago

@sdaitzman No, it was just displayed when creating content from a collections page.