Open ChrisChV opened 1 month ago
@ChrisChV I think this should actually be using FilterByTags
, not ContentTagsDropDownSelector
. Because ContentTagsDropDownSelector
is not for filtering - it displays all available tags. Whereas FilterByTags
is for filtering search results, and it only shows the tags that are actually used in the library. Plus it's already using the right UI.
@ChrisChV For your other questions, it should work the same way as the course search modal that we built.
@bradenmacdonald Thanks for the info!
TBA When apply the filter. It must maintain the https://github.com/openedx/frontend-app-course-authoring/issues/1038 and https://github.com/openedx/frontend-app-course-authoring/issues/1049 currently applied
This functionality is already implemented for the course search modal. You can re-use the same components, so you don't have to re-implement this.
Reuse the FilterByTags code as much as possible.
Don't re-use the code - just use FilterByTags
directly :) It should already work perfectly for this use case and not need any changes.
@ChrisChV @bradenmacdonald There seems to be 2 styles in the Figma for how the filters should look like:
Style 1:
Style 2:
They are next to each other in Figma, however I'm not sure which one is the final one we are going with?
@yusuf-musleh This is the Hifi Header
@yusuf-musleh @ChrisChV The filter components already exist - just re-use the existing ones that we have. They look more like "Style 1".
I think they don't have icons though, so adding icons would be a nice addition, but not necessary for the MVP.
@bradenmacdonald @ChrisChV Got it, thanks for the clarification.
Yes we're using the existing components, i've added the icons as well, in this PR.
Mockups: Figma mid-fi
Clear filter
button removes the selected tags.