Closed OmarIthawi closed 1 year ago
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Patch and project coverage have no change.
Comparison is base (
b2b33b7
) 91.88% compared to head (2c186d1
) 91.88%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@OmarIthawi looks like a conflict was introduced, can you have a look?
@e0d the conflicts seems to be resolve for other reasons.
@jristau1984 @asadazam93 the spreadsheet says to inform you before merging this. It's ready to go, any reason I should hold off?
@OmarIthawi looks like this has a conflict again
@brian-smith-tcril done. cc: @jristau1984 @asadazam93
@OmarIthawi looks like tests are failing on this one now
Those in principle, shouldn't fail. But I'm looking into them anyway.
@OmarIthawi we have another PR that upgrades the frontend platform version. I think it would make sense to merge that one first.
@asadazam93 yes please, I'd love it if that happens soon :)
I'm marking this as "blocked by other work" until https://github.com/openedx/frontend-app-discussions/issues/518 is resolved. I'll revisit next week and if the failing tests on master are still not resolved I'll consider merging it with failing tests.
Yes, it's ready for merge @awais-ansari. Thanks for checking.
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Changes
src/i18n/index.js
sointl-imports.js
can override it with latest translationsatlas
intomake pull_translations
whenOPENEDX_ATLAS_PULL
environment variable is set.Testing
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes:
For Micro-frontends:
src/i18n/index.js
atlas
integration inmake pull_translations
but only ifOPENEDX_ATLAS_PULL
is setintl-imports.js
to generate up to date import files