openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 62 forks source link

build: edx namespace packages upgrade & resolved respective eslint issue #508

Closed BilalQamar95 closed 1 year ago

BilalQamar95 commented 1 year ago

Description

This PR upgrades @edx/frontend-build along with @edx/frontend-component-footer, @edx/frontend-component-header, @edx/frontend-platform packages & resolves respective eslint issues.

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

Post-merge Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 87.83% and project coverage change: +0.13 :tada:

Comparison is base (8228549) 91.74% compared to head (4f75a10) 91.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #508 +/- ## ========================================== + Coverage 91.74% 91.88% +0.13% ========================================== Files 170 170 Lines 3464 3474 +10 Branches 900 905 +5 ========================================== + Hits 3178 3192 +14 + Misses 267 263 -4 Partials 19 19 ``` | [Impacted Files](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [src/components/icons/InsertLink.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvaWNvbnMvSW5zZXJ0TGluay5qc3g=) | `100.00% <ø> (ø)` | | | [src/components/icons/Issue.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvaWNvbnMvSXNzdWUuanN4) | `100.00% <ø> (ø)` | | | [src/components/icons/People.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvaWNvbnMvUGVvcGxlLmpzeA==) | `0.00% <ø> (ø)` | | | [src/components/icons/PushPin.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvaWNvbnMvUHVzaFBpbi5qc3g=) | `100.00% <ø> (ø)` | | | [src/components/icons/Question.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvaWNvbnMvUXVlc3Rpb24uanN4) | `100.00% <ø> (ø)` | | | [src/components/icons/QuestionAnswer.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvaWNvbnMvUXVlc3Rpb25BbnN3ZXIuanN4) | `0.00% <ø> (ø)` | | | [src/components/icons/QuestionAnswerOutline.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvaWNvbnMvUXVlc3Rpb25BbnN3ZXJPdXRsaW5lLmpzeA==) | `100.00% <ø> (ø)` | | | [src/components/icons/StarFilled.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvaWNvbnMvU3RhckZpbGxlZC5qc3g=) | `100.00% <ø> (ø)` | | | [src/components/icons/StarOutline.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvaWNvbnMvU3Rhck91dGxpbmUuanN4) | `100.00% <ø> (ø)` | | | [src/components/icons/ThumbUpFilled.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvaWNvbnMvVGh1bWJVcEZpbGxlZC5qc3g=) | `100.00% <ø> (ø)` | | | ... and [29 more](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/508?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

BilalQamar95 commented 1 year ago

@BilalQamar95 Please resolve conflicts. The CI pipeline is unblocked now. We can merge this PR after proper testing. Thanks.

@awais-ansari I have resolved the conflicts, PR is now ready for review.

BilalQamar95 commented 1 year ago

Some minor nits. Rest looks good.

Can we change function definitions to 'const functionName = async() => {}' in the following files

src/discussions/post-comments/data/api.js src/discussions/posts/data/api.js

@muhammadadeeltajamul Updated PR with suggested changes

abdullahwaheed commented 1 year ago

@awais-ansari could you please review and merge this PR