Closed BilalQamar95 closed 1 year ago
Patch coverage: 87.83
% and project coverage change: +0.13
:tada:
Comparison is base (
8228549
) 91.74% compared to head (4f75a10
) 91.88%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@BilalQamar95 Please resolve conflicts. The CI pipeline is unblocked now. We can merge this PR after proper testing. Thanks.
@awais-ansari I have resolved the conflicts, PR is now ready for review.
Some minor nits. Rest looks good.
Can we change function definitions to 'const functionName = async() => {}' in the following files
src/discussions/post-comments/data/api.js src/discussions/posts/data/api.js
@muhammadadeeltajamul Updated PR with suggested changes
@awais-ansari could you please review and merge this PR
Description
This PR upgrades
@edx/frontend-build
along with@edx/frontend-component-footer, @edx/frontend-component-header, @edx/frontend-platform
packages & resolves respectiveeslint
issues.How Has This Been Tested?
Please describe in detail how you tested your changes.
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.
Merge Checklist
Post-merge Checklist