fix: post sharing URL - Githubissues

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.

GNU Affero General Public License v3.0

6 stars 63 forks source link

fix: post sharing URL #519

Closed dyudyunov closed 1 year ago

dyudyunov commented 1 year ago

When MFE uses path-based deployment (common domain for all MFEs divided by path) - the copied link leads to 404 error.

The fix:

construct a Post URL using MFE's PUBLIC_PATH env var
works for both subdomain and subdirectory-based deployments

This is a backport of https://github.com/openedx/frontend-app-discussions/pull/445

openedx-webhooks commented 1 year ago

Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (open-release/palm.master@35541c9). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## open-release/palm.master #519 +/- ## =========================================================== Coverage ? 92.13% =========================================================== Files ? 163 Lines ? 3253 Branches ? 889 =========================================================== Hits ? 2997 Misses ? 237 Partials ? 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mphilbrick211 commented 1 year ago

Hi @asadazam93 and @arbrandes - flagging this as it's related to #445

arbrandes commented 1 year ago

@mphilbrick211, we can merge this once the corresponding PR to master lands.

dyudyunov commented 1 year ago

@dyudyunov Please rebase this branch with master. The PUBLIC_PATH issue has been addressed on the master.

hi @awais-ansari I'll rebase ASAP, thanks!

dyudyunov commented 1 year ago

@dyudyunov Please rebase this branch with master. The PUBLIC_PATH issue has been addressed on the master.

already up to date

openedx-webhooks commented 1 year ago

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.