openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 63 forks source link

fix: Upgraded mathjax version 3 to 3.0.1 #530

Closed ManpraXSoftware closed 1 year ago

ManpraXSoftware commented 1 year ago

Description

Equation is working correctly with previous version as well but when we do right click on equation and change options, it refresh equation, at that time, it is not being rendered it correctly.

How Has This Been Tested?

Right click on equation and enable accessibility, it will render equation again, equation will be disappear and when you refresh whole page then it starts to work.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @ManpraXSoftware! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c8500a0) 91.82% compared to head (dc34ba8) 91.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #530 +/- ## ======================================= Coverage 91.82% 91.82% ======================================= Files 170 170 Lines 3476 3476 Branches 905 905 ======================================= Hits 3192 3192 Misses 265 265 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

itsjeyd commented 1 year ago

Hi @ManpraXSoftware, thank you for your contribution!

Please amend your commit message(s) to conform to Conventional Commits standards, and update your branch with the latest changes from master.

Once that's done and the build is green we can line your changes up for engineering review.

itsjeyd commented 1 year ago

Hey @ManpraXSoftware, a friendly ping about amending your commit messages ⬆️ and updating the PR branch with latest master.

itsjeyd commented 1 year ago

Hi @ManpraXSoftware, just checking in to see if we should keep this PR open?

itsjeyd commented 1 year ago

Hi @ManpraXSoftware! Thanks again for this contribution. We're closing this PR now because it is stale. You may reopen this pull request, or open a new one, when you have time to come back to this work.

CC @asadazam93