Closed DmytroAlipov closed 1 year ago
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Patch coverage: 50.00
% and project coverage change: -0.03
:warning:
Comparison is base (
2563209
) 85.07% compared to head (6ee2d4b
) 85.05%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @awais-ansari. I created two more PRs in Master and Palm branches. For those PRs, the pipelines went well. The current PR does not pass the coverage check. The code is the same in all PRs. Could you help me solve this issue?
@DmytroAlipov you can add a test case related to your change in this file.
@awais-ansari In the olive release, this file is configured completely differently. not like in the file on this link. and in order to write this test, you need to completely rewrite the logic of this file. And taking into account the fact that there will be no new olive releases, I see no reason to waste time on this.
@awais-ansari In the olive release, this file is configured completely differently. not like in the file on this link. and in order to write this test, you need to completely rewrite the logic of this file. And taking into account the fact that there will be no new olive releases, I see no reason to waste time on this.
@DmytroAlipov it makes sense. The team will review this PR shortly.
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description
An issue has been found with research if no changes are made to the search field:
first search:
second search:
This fix allows actions to be ignored if the current search query matches a previous query. If there are any changes in the search query, then it is sent to the backend.