openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 62 forks source link

Fix bug with a repeated search query for Olive #539

Closed DmytroAlipov closed 1 year ago

DmytroAlipov commented 1 year ago

Description

An issue has been found with research if no changes are made to the search field:

This fix allows actions to be ignored if the current search query matches a previous query. If there are any changes in the search query, then it is sent to the backend.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.03 :warning:

Comparison is base (2563209) 85.07% compared to head (6ee2d4b) 85.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/olive.master #539 +/- ## ============================================================= - Coverage 85.07% 85.05% -0.03% ============================================================= Files 134 134 Lines 2680 2683 +3 Branches 743 743 ============================================================= + Hits 2280 2282 +2 - Misses 378 379 +1 Partials 22 22 ``` | [Impacted Files](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [src/components/Search.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvU2VhcmNoLmpzeA==) | `71.05% <50.00%> (-0.38%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

DmytroAlipov commented 1 year ago

Hi @awais-ansari. I created two more PRs in Master and Palm branches. For those PRs, the pipelines went well. The current PR does not pass the coverage check. The code is the same in all PRs. Could you help me solve this issue?

awais-ansari commented 1 year ago

Hi @awais-ansari. I created two more PRs in Master and Palm branches. For those PRs, the pipelines went well. The current PR does not pass the coverage check. The code is the same in all PRs. Could you help me solve this issue?

@DmytroAlipov you can add a test case related to your change in this file.

DmytroAlipov commented 1 year ago

@awais-ansari In the olive release, this file is configured completely differently. not like in the file on this link. and in order to write this test, you need to completely rewrite the logic of this file. And taking into account the fact that there will be no new olive releases, I see no reason to waste time on this.

awais-ansari commented 1 year ago

@awais-ansari In the olive release, this file is configured completely differently. not like in the file on this link. and in order to write this test, you need to completely rewrite the logic of this file. And taking into account the fact that there will be no new olive releases, I see no reason to waste time on this.

@DmytroAlipov it makes sense. The team will review this PR shortly.

openedx-webhooks commented 1 year ago

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.