openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 62 forks source link

Fix bug with a repeated search query for Palm #541

Closed DmytroAlipov closed 1 year ago

DmytroAlipov commented 1 year ago

Description

An issue has been found with research if no changes are made to the search field:

This fix allows actions to be ignored if the current search query matches a previous query. If there are any changes in the search query, then it is sent to the backend.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e801fbb) 92.38% compared to head (dcb0f9e) 92.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/palm.master #541 +/- ## ========================================================= Coverage 92.38% 92.38% ========================================================= Files 163 163 Lines 3294 3297 +3 Branches 890 890 ========================================================= + Hits 3043 3046 +3 Misses 232 232 Partials 19 19 ``` | [Impacted Files](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [src/components/Search.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvU2VhcmNoLmpzeA==) | `92.10% <100.00%> (+0.67%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

itsjeyd commented 1 year ago

@DmytroAlipov Thanks for the PR! I'm marking the changes as ready for review, but let me know if you're still planning to work on them some more.

awais-ansari commented 1 year ago

@DmytroAlipov Thank you for this contribution! The Team will review this PR Shortly.

openedx-webhooks commented 1 year ago

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.