openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 62 forks source link

test: fixed postcommentsview test cases #543

Closed ayesha-waris closed 1 year ago

ayesha-waris commented 1 year ago

INF-926

Description

Some test cases were failing due to structure of comments factory used in PostCommentsView Tests. This ticket intends to add those removed test cases and fix comments factory.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.43 :tada:

Comparison is base (e2bb68a) 91.86% compared to head (c14a737) 92.30%.

:exclamation: Current head c14a737 differs from pull request most recent head 8c3f523. Consider uploading reports for the commit 8c3f523 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #543 +/- ## ========================================== + Coverage 91.86% 92.30% +0.43% ========================================== Files 170 170 Lines 3468 3468 Branches 904 904 ========================================== + Hits 3186 3201 +15 + Misses 263 246 -17 - Partials 19 21 +2 ``` | [Impacted Files](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/543?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [...st-comments/data/\_\_factories\_\_/comments.factory.js](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/543?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2Rpc2N1c3Npb25zL3Bvc3QtY29tbWVudHMvZGF0YS9fX2ZhY3Rvcmllc19fL2NvbW1lbnRzLmZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/543/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.