Closed CodeWithEmad closed 10 months ago
Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Also, I noticed that you're using the es-AR
and es-ES
inside i18n/index.js
https://github.com/openedx/frontend-app-discussions/blob/ea235cf6ca707521adbc90938f928c7816a8029d/src/i18n/index.js#L41-L42
but I believe in other MFEs (even here of fr-fr or fr-cs) the language code should be all in lowercase.
Is there a specific reason for the issue, or should I address it in my PR?
Hey @asadazam93, would you be able to help @CodeWithEmad with the question that he raised above?
@CodeWithEmad Thanks for the changes!
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3a6a783
) 92.32% compared to head (1c64979
) 92.32%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @CodeWithEmad , I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?
Sure. I totally forgot about the commit lint. have a look now :)
@e0d since no one answered my question about the UPPER case codes for es-ES
and es-AR
, I refactor them as well to es-es
and es-ar
and rebased with master.
Hey @arbrandes, has this PR made it into your review queue? If you don't think you'll get to this PR anytime soon, I can try and find someone else to review; just let me know.
Hi @arbrandes! Just following up on this to see if you're able to review (and if you could please re-enable the checks to run)? Thanks!
CC: @itsjeyd
@arbrandes Since your review queue is quite long (😅), would it help if we asked someone from the maintainer team (Infinity) to review this PR?
CC @mphilbrick211
@saadyousafarbi take a look.
I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?
Oops. I forgot that, again! It's okay now, @e0d.
Hi @arbrandes! When you get a chance, could you please re-enable the checks to run on this PR before review? Thanks!
@mphilbrick211 @arbrandes Since @saadyousafarbi already reviewed and approved these changes I didn't think we'd need another round of review.
The build is green, too, so it looks like this PR is pretty much ready for merge.
Hey @CodeWithEmad, could you please rebase your changes?
@saadyousafarbi Once that's done would you be able to merge this PR?
@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
This will fix the Persian language code issue(fa-ir is the code in all of the other MFEs) also fixed some typos in the code.