openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 62 forks source link

refactor: updated lock file version check to use new workflow #559

Closed Mashal-m closed 10 months ago

Mashal-m commented 1 year ago

Description

Renamed lockfileversion-check-v3 to lockfile-check in lockfile version file.

Ticket

Prototype a way to review NPM lockfiles in PRs

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

Post-merge Checklist

codecov[bot] commented 12 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4994de9) 92.37% compared to head (e79ad9a) 92.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #559 +/- ## ======================================= Coverage 92.37% 92.37% ======================================= Files 169 169 Lines 3450 3450 Branches 898 898 ======================================= Hits 3187 3187 Misses 243 243 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

awais-ansari commented 10 months ago

Hi @Mashal-m, Just to confirm. Are you still working on this PR? We are planning the board cleanup. Should I close this PR?

sundasnoreen12 commented 10 months ago

Hi @Mashal-m any updates on this PR?

Mashal-m commented 10 months ago

It is ready to review and merge.

Hi @Mashal-m any updates on this PR?