search

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 62 forks source link

feat: Profile image on user posts (palm.master) #573

Open vladislavkeblysh opened 11 months ago

vladislavkeblysh commented 11 months ago

Description

Screenshot 2023-10-11 at 19 01 23

openedx-webhooks commented 11 months ago

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 10 months ago

@vladislavkeblysh Thank you for this contribution!

mphilbrick211 commented 10 months ago

Hi @vladislavkeblysh! Just flagging that there is a failing check.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dcb0f9e) 92.38% compared to head (25221c9) 92.41%. Report is 4 commits behind head on open-release/palm.master.

Files Patch % Lines
...c/discussions/discussions-home/FeedbackWrapper.jsx 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/palm.master #573 +/- ## ============================================================ + Coverage 92.38% 92.41% +0.02% ============================================================ Files 163 162 -1 Lines 3297 3282 -15 Branches 890 887 -3 ============================================================ - Hits 3046 3033 -13 + Misses 232 230 -2 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

itsjeyd commented 10 months ago

@vladislavkeblysh Looks like there are some coverage issues, can you have a look?

vladislavkeblysh commented 10 months ago

@itsjeyd The coverage issues are not related to the new code added in this PR. It seems like this has been carrying over from previous PRs.

itsjeyd commented 10 months ago

@vladislavkeblysh I see -- the line that the codecov check is complaining about wasn't changed in this PR. Thanks for checking.

That probably means it's OK to merge the changes as is, but it'll be up to engineering reviewers to make the final call on that.

awais-ansari commented 10 months ago

@vladislavkeblysh This change was intentional. This feature is still in product discussion.