Open vladislavkeblysh opened 11 months ago
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Hey @vladislavkeblysh, thank you for this contribution!
@jmakowski1123 This seems to be a user-facing change, so we would need a feature ticket for it. Could you please create one?
CC @mphilbrick211
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b5d036a
) 92.41% compared to head (d738b6f
) 92.42%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jmakowski1123 When you get a minute could you please create a feature ticket for this PR and the backports listed above?
@jmakowski1123 @awais-ansari It sounds like product review for this PR has already started (?). If so, could you please point me to where that conversation is happening? It doesn't seem like we have a feature ticket for this PR, so it's hard for me to tell what its current status is.
CC @mphilbrick211
@vladislavkeblysh Just to keep you in the loop, we're still working on getting this PR unblocked. The same goes for the other PRs that you opened in this repo (#577 and Palm/Quince backports, #582 and Palm/Quince backports).
CC @mphilbrick211
@vladislavkeblysh @itsjeyd I started a thread on the openEdx slack to speed up the process. CC: @mphilbrick211
I can let Product handle the question in more detail, but my understanding is that some sites don't want this due to privacy concerns, so it may need to be the operator's choice whether to enable it.
Apologies for the delay. Lots of open questions regarding this PR, please see here: https://github.com/openedx/platform-roadmap/issues/314#issuecomment-1854930337
Thanks a lot for the update and product feedback @jmakowski1123! 🙂
@vladislavkeblysh Product review will continue via https://github.com/openedx/platform-roadmap/issues/314, the feature ticket for this PR. Please have a look at that ticket when you can and address the questions raised in this comment.
CC @awais-ansari @mphilbrick211
Description