openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 62 forks source link

feat: Profile image on user posts #574

Open vladislavkeblysh opened 11 months ago

vladislavkeblysh commented 11 months ago

Description

Screenshot 2023-10-11 at 19 01 23

openedx-webhooks commented 11 months ago

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 10 months ago

Hey @vladislavkeblysh, thank you for this contribution!

@jmakowski1123 This seems to be a user-facing change, so we would need a feature ticket for it. Could you please create one?

CC @mphilbrick211

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b5d036a) 92.41% compared to head (d738b6f) 92.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #574 +/- ## ======================================= Coverage 92.41% 92.42% ======================================= Files 169 169 Lines 3468 3472 +4 Branches 900 904 +4 ======================================= + Hits 3205 3209 +4 Misses 243 243 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

itsjeyd commented 10 months ago

@jmakowski1123 When you get a minute could you please create a feature ticket for this PR and the backports listed above?

itsjeyd commented 9 months ago

@jmakowski1123 @awais-ansari It sounds like product review for this PR has already started (?). If so, could you please point me to where that conversation is happening? It doesn't seem like we have a feature ticket for this PR, so it's hard for me to tell what its current status is.

CC @mphilbrick211

itsjeyd commented 9 months ago

@vladislavkeblysh Just to keep you in the loop, we're still working on getting this PR unblocked. The same goes for the other PRs that you opened in this repo (#577 and Palm/Quince backports, #582 and Palm/Quince backports).

CC @mphilbrick211

awais-ansari commented 9 months ago

@vladislavkeblysh @itsjeyd I started a thread on the openEdx slack to speed up the process. CC: @mphilbrick211

nedbat commented 9 months ago

I can let Product handle the question in more detail, but my understanding is that some sites don't want this due to privacy concerns, so it may need to be the operator's choice whether to enable it.

jmakowski1123 commented 9 months ago

Apologies for the delay. Lots of open questions regarding this PR, please see here: https://github.com/openedx/platform-roadmap/issues/314#issuecomment-1854930337

itsjeyd commented 9 months ago

Thanks a lot for the update and product feedback @jmakowski1123! 🙂

@vladislavkeblysh Product review will continue via https://github.com/openedx/platform-roadmap/issues/314, the feature ticket for this PR. Please have a look at that ticket when you can and address the questions raised in this comment.

CC @awais-ansari @mphilbrick211