feat: Profile image on user posts (quince.master)

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.

GNU Affero General Public License v3.0

6 stars 62 forks source link

feat: Profile image on user posts (quince.master) #575

Open vladislavkeblysh opened 11 months ago

vladislavkeblysh commented 11 months ago

Description

Added profile image on user avatar posts

Screenshot 2023-10-11 at 19 01 23

openedx-webhooks commented 11 months ago

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 10 months ago

@vladislavkeblysh Thank you for this contribution!

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (open-release/quince.master@eb127cd). Click here to learn what that means.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## open-release/quince.master #575 +/- ## ============================================================= Coverage ? 92.32% ============================================================= Files ? 169 Lines ? 3455 Branches ? 903 ============================================================= Hits ? 3190 Misses ? 244 Partials ? 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

awais-ansari commented 10 months ago

@vladislavkeblysh This change was intentional. This feature is still in product discussion.

arbrandes commented 9 months ago

Is this ready to merge?

cmltaWt0 commented 9 months ago

It hasn't yet been merged with the master. https://github.com/openedx/frontend-app-discussions/pull/574

mphilbrick211 commented 9 months ago

Is this ready to merge?

@arbrandes we're waiting to see if Product needs to review.

itsjeyd commented 9 months ago

This change will need product approval before merging it, see https://github.com/openedx/frontend-app-discussions/pull/574#issuecomment-1854931136.