search

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 62 forks source link

feat: Enhancements to page (palm.master) #576

Closed vladislavkeblysh closed 9 months ago

vladislavkeblysh commented 11 months ago

Screenshot 2023-10-12 at 15 07 45 Screenshot 2023-10-12 at 15 07 18 Screenshot 2023-10-12 at 15 08 31 Screenshot 2023-10-12 at 15 08 15 Screenshot 2023-10-12 at 15 09 05 Screenshot 2023-10-12 at 15 08 51 Screenshot 2023-10-12 at 15 10 31 Screenshot 2023-10-12 at 15 10 14

openedx-webhooks commented 11 months ago

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 10 months ago

@vladislavkeblysh Thank you for this contribution!

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dcb0f9e) 92.38% compared to head (f8daf7a) 92.40%. Report is 4 commits behind head on open-release/palm.master.

Files Patch % Lines
...c/discussions/discussions-home/FeedbackWrapper.jsx 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/palm.master #576 +/- ## ============================================================ + Coverage 92.38% 92.40% +0.01% ============================================================ Files 163 162 -1 Lines 3297 3278 -19 Branches 890 883 -7 ============================================================ - Hits 3046 3029 -17 + Misses 232 230 -2 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

itsjeyd commented 10 months ago

@vladislavkeblysh Looks like there are some coverage issues, can you have a look?

vladislavkeblysh commented 10 months ago

@itsjeyd The coverage issues are not related to the new code added in this PR. It seems like this has been carrying over from previous PRs.

itsjeyd commented 10 months ago

@vladislavkeblysh Noted, thanks.

As I mentioned here, your reviewers will need to decide if that means the changes are good to merge as is.

awais-ansari commented 10 months ago

@vladislavkeblysh please resolve conflict. Some changes have been suggested here.

awais-ansari commented 10 months ago

@vladislavkeblysh This change was intentional. This feature is still in product discussion.

vladislavkeblysh commented 9 months ago

@awais-ansari All comments fixed and branch updated.

The coverage issues are not related to the new code added in this PR. It seems like this has been carrying over from previous PRs.

mphilbrick211 commented 9 months ago

PR LGTM

We're just waiting on Product to confirm review.

openedx-webhooks commented 9 months ago

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.