search

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 62 forks source link

feat: Enhancements to page #577

Closed vladislavkeblysh closed 8 months ago

vladislavkeblysh commented 11 months ago

Screenshot 2023-10-12 at 15 07 45 Screenshot 2023-10-12 at 15 07 18 Screenshot 2023-10-12 at 15 08 31 Screenshot 2023-10-12 at 15 08 15 Screenshot 2023-10-12 at 15 09 05 Screenshot 2023-10-12 at 15 08 51 Screenshot 2023-10-12 at 15 10 31 Screenshot 2023-10-12 at 15 10 14

openedx-webhooks commented 11 months ago

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 10 months ago

@vladislavkeblysh Thank you for this contribution!

@jmakowski1123 With this set of changes I'm not sure if we need to step through the full product review process. It seems like they are just fixing some small visual inconsistencies. What do you think?

CC @mphilbrick211

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (67d79cb) 92.41% compared to head (009ccce) 92.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #577 +/- ## ======================================= Coverage 92.41% 92.41% ======================================= Files 169 169 Lines 3468 3468 Branches 900 900 ======================================= Hits 3205 3205 Misses 243 243 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

itsjeyd commented 10 months ago

@jmakowski1123 Friendly ping about this question -- do you think this PR needs a round of product review?

itsjeyd commented 9 months ago

@jmakowski1123 @awais-ansari It sounds like product review for this PR has already started (?). If so, could you please point me to where that conversation is happening? It doesn't seem like we have a feature ticket for this PR, so it's hard for me to tell what its current status is.

CC @mphilbrick211

awais-ansari commented 9 months ago

@mphilbrick211 Is this PR still in a product review? or is it ready for merge?

mphilbrick211 commented 9 months ago

@mphilbrick211 Is this PR still in a product review? or is it ready for merge?

@awais-ansari We haven't heard back from Product - so please hold off on merging.

CC: @jmakowski1123

jmakowski1123 commented 9 months ago

This is approved.

awais-ansari commented 9 months ago

@vladislavkeblysh Please update this PR.

vladislavkeblysh commented 9 months ago

@awais-ansari Done, thank you

mphilbrick211 commented 8 months ago

All set to merge, @awais-ansari!

awais-ansari commented 8 months ago

@vladislavkeblysh can you please update this PR one more time?

openedx-webhooks commented 8 months ago

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.