feat: Enhancements to page (quince.master)

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.

GNU Affero General Public License v3.0

6 stars 62 forks source link

feat: Enhancements to page (quince.master) #578

Closed vladislavkeblysh closed 9 months ago

vladislavkeblysh commented 11 months ago

Fixed font family on page
Fixed borders on action bar on mobile view
Fixed newest first text overlap another text
Fixed displaying user name on mobile view

Screenshot 2023-10-12 at 15 07 45 Screenshot 2023-10-12 at 15 08 31 Screenshot 2023-10-12 at 15 09 05 Screenshot 2023-10-12 at 15 10 31

openedx-webhooks commented 11 months ago

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 10 months ago

@vladislavkeblysh Thank you for this contribution!

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (open-release/quince.master@eb127cd). Click here to learn what that means.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## open-release/quince.master #578 +/- ## ============================================================= Coverage ? 92.32% ============================================================= Files ? 169 Lines ? 3451 Branches ? 899 ============================================================= Hits ? 3186 Misses ? 244 Partials ? 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

awais-ansari commented 10 months ago

@vladislavkeblysh please resolve conflict. Some changes have been suggested here.

itsjeyd commented 9 months ago

Hi @vladislavkeblysh, a friendly reminder to follow up on @awais-ansari's latest comment about resolving conflicts, and to address feedback that you got from @sundasnoreen12 on the main PR for this change (#577).

vladislavkeblysh commented 9 months ago

@itsjeyd I will fix it soon, thank you!

vladislavkeblysh commented 9 months ago

@itsjeyd All comments fixed and branch updated.

arbrandes commented 9 months ago

Is this now just a matter of pressing the merge button? Should I do it? :)

cmltaWt0 commented 9 months ago

The master PR still in open state. https://github.com/openedx/frontend-app-discussions/pull/577

openedx-webhooks commented 9 months ago

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.