feat: Editor bar visibility

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.

GNU Affero General Public License v3.0

6 stars 61 forks source link

feat: Editor bar visibility #582

Closed vladislavkeblysh closed 7 months ago

vladislavkeblysh commented 9 months ago

Description

Fixed editor bar visibility when scrolling up

Screenshot 2023-10-16 at 12 09 51 Screenshot 2023-10-16 at 12 10 13

openedx-webhooks commented 9 months ago

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 9 months ago

@vladislavkeblysh Thank you for this contribution!

@jmakowski1123 Another set of changes that may or may not require product review.

Palm backport: #581
Quince backport: #583

CC @mphilbrick211

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b467298) 92.41% compared to head (42a26e4) 92.41%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #582 +/- ## ======================================= Coverage 92.41% 92.41% ======================================= Files 169 169 Lines 3468 3468 Branches 900 900 ======================================= Hits 3205 3205 Misses 243 243 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ayub02 commented 9 months ago

@awais-ansari this looks good to me.

mphilbrick211 commented 9 months ago

HI @jmakowski1123 - does this have a master product ticket?

jmakowski1123 commented 7 months ago

This is approved.

awais-ansari commented 7 months ago

@vladislavkeblysh did you get a chance to review this change? This is still breaking the UI.

itsjeyd commented 7 months ago

This is approved.

Thank you @jmakowski1123.

@vladislavkeblysh Changing status to In Eng Review now, for this PR and Palm/Quince backports (#581, #583).

CC @awais-ansari

vladislavkeblysh commented 7 months ago

@awais-ansari I will see it soon, thank you for reminding!

vladislavkeblysh commented 7 months ago

@awais-ansari Fixed

awais-ansari commented 7 months ago

@vladislavkeblysh Please update the PR.

vladislavkeblysh commented 7 months ago

@awais-ansari done

openedx-webhooks commented 7 months ago

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.