feat: Editor bar visibility (quince.master)

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.

GNU Affero General Public License v3.0

6 stars 61 forks source link

feat: Editor bar visibility (quince.master) #583

Closed vladislavkeblysh closed 7 months ago

vladislavkeblysh commented 9 months ago

Description

Fixed editor bar visibility when scrolling up

Screenshot 2023-10-16 at 12 09 51 Screenshot 2023-10-16 at 12 10 13

openedx-webhooks commented 9 months ago

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 9 months ago

@vladislavkeblysh Thank you for this contribution!

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (open-release/quince.master@eb127cd). Click here to learn what that means.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## open-release/quince.master #583 +/- ## ============================================================= Coverage ? 92.43% ============================================================= Files ? 169 Lines ? 3451 Branches ? 898 ============================================================= Hits ? 3190 Misses ? 241 Partials ? 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

awais-ansari commented 9 months ago

@vladislavkeblysh breaking changes have been mentioned here.

vladislavkeblysh commented 9 months ago

@awais-ansari I have seen it. I will fix it soon, thank you

arbrandes commented 8 months ago

Do we just need to press the merge button, now? Are all issues fixed?

cmltaWt0 commented 7 months ago

Master PR: https://github.com/openedx/frontend-app-discussions/pull/582

itsjeyd commented 7 months ago

@arbrandes

Do we just need to press the merge button, now? Are all issues fixed?

There seem to be some issues left to fix on the master PR, so @vladislavkeblysh might need to update this PR and the Palm backport (#581) with some follow-up changes to get them ready for merge.

vladislavkeblysh commented 7 months ago

@awais-ansari @mphilbrick211 Fixed comment from master

openedx-webhooks commented 7 months ago

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.