feat!: remove Transifex calls for OEP-58

hopewise commented 9 months ago

Breaking change!

This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.

Changes

Removes all direct use of tx pull and tx push commands from the micro-frontend in favor of the atlas pull command.
Remove source and language translations from the repositories, hence no .json files will be committed into the repos.
src/i18n/index.js should export and empty array so the make pull_translations override it with the dynamic list of languages.
Remove the experimental OPENEDX_ATLAS_PULL flag to make atlas pull the default.
Remove all Transifex related Makefile targets and other files.

Test results

[ ] Verify that make pull_translations works as expected.

make pull_translations test results

``` # I've run the following commands: $ make requirements $ make pull_translations $ git diff # Output of the commmands: make pull_translations rm -rf src/i18n/messages mkdir src/i18n/messages cd src/i18n/messages \ && atlas pull --filter= \ translations/frontend-component-header/src/i18n/messages:frontend-component-header \ translations/frontend-component-footer/src/i18n/messages:frontend-component-footer \ translations/paragon/src/i18n/messages:paragon \ translations/frontend-app-discussions/src/i18n/messages:frontend-app-discussions Pulling translation files - directory: translations/frontend-component-header/src/i18n/messages:frontend-component-header translations/frontend-component-footer/src/i18n/messages:frontend-component-footer translations/paragon/src/i18n/messages:paragon translations/frontend-app-discussions/src/i18n/messages:frontend-app-discussions - repository: openedx/openedx-translations - branch: main - filter: Not Specified - expand-glob: Not Specified Creating a temporary Git repository to pull translations into "./translations_TEMP"... Done. Setting git sparse-checkout rules... Done. Pulling translation files from the repository... remote: Enumerating objects: 55, done. remote: Counting objects: 100% (55/55), done. remote: Compressing objects: 100% (29/29), done. remote: Total 55 (delta 40), reused 35 (delta 26), pack-reused 0 Receiving objects: 100% (55/55), 82.34 KiB | 896.00 KiB/s, done. Resolving deltas: 100% (40/40), done. Updating files: 100% (55/55), done. Your branch is up to date with 'origin/main'. Done. Copying translations from "./translations_TEMP/translations/frontend-component-header/src/i18n/messages" to "./frontend-component-header"... Done. Copying translations from "./translations_TEMP/translations/frontend-component-footer/src/i18n/messages" to "./frontend-component-footer"... Done. Copying translations from "./translations_TEMP/translations/paragon/src/i18n/messages" to "./paragon"... Done. Copying translations from "./translations_TEMP/translations/frontend-app-discussions/src/i18n/messages" to "./frontend-app-discussions"... Done. Removing temporary directory... Done. Translations pulled successfully! ./node_modules/.bin/intl-imports.js frontend-component-header frontend-component-footer paragon frontend-app-discussions ```

Merge timeline

This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.

The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.

Keep this pull request as a draft to prevent accidental merge.

Pre-merge checklist

[ ] Wait for approval on https://github.com/openedx/wg-translations/issues/20

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

openedx-webhooks commented 9 months ago

Thanks for the pull request, @hopewise! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

e0d commented 9 months ago

@hopewise I notice there are conflicts that need attention, but understand this PR is prone to conflicts. Just make sure to resolve when it's ready to leave draft status.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.82%. Comparing base (1a2068d) to head (be53e63).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #586 +/- ## ======================================= Coverage 92.82% 92.82% ======================================= Files 158 158 Lines 3331 3331 Branches 919 919 ======================================= Hits 3092 3092 Misses 219 219 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brian-smith-tcril commented 4 months ago

it seems these changes made it in via https://github.com/openedx/frontend-app-discussions/pull/682

openedx-webhooks commented 4 months ago

@hopewise Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx / frontend-app-discussions