openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 61 forks source link

refactor: updated README file to reflect template changes #592

Closed Mashal-m closed 9 months ago

Mashal-m commented 9 months ago

Description

The README of the MFEs needs to be updated because the frontend app template has been updated.

Issue related: https://github.com/openedx/wg-frontend/issues/169

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

Post-merge Checklist

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1cb8ad3) 92.32% compared to head (95d5cf0) 92.32%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #592 +/- ## ======================================= Coverage 92.32% 92.32% ======================================= Files 169 169 Lines 3451 3451 Branches 899 899 ======================================= Hits 3186 3186 Misses 244 244 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sundasnoreen12 commented 9 months ago

@Mashal-m Please resolve the conflict in the README.rst file. Once this is done, I will perform a final review.

Mashal-m commented 9 months ago

@Mashal-m Please resolve the conflict in the README.rst file. Once this is done, I will perform a final review.

conflicts resolved!