openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 61 forks source link

fix: unify font-family with paragon component styles #598

Closed ihor-romaniuk closed 9 months ago

ihor-romaniuk commented 9 months ago

Description

This pull request contains recommendations for fixing custom font-family and make it unified with all MFEs and Paragon components. All MFEs must have the same default appearance and change them globally via brand-openedx component on demand.

Related Pull Requests

PR to the open-release/palm.master branch: https://github.com/openedx/frontend-app-discussions/pull/596 PR to the open-release/quince.master branch: https://github.com/openedx/frontend-app-discussions/pull/597

Screenshots/sandbox (optional):

Before After
image image

Merge Checklist

Post-merge Checklist

openedx-webhooks commented 9 months ago

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6d90da7) 92.37% compared to head (5851321) 92.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #598 +/- ## ======================================= Coverage 92.37% 92.37% ======================================= Files 169 169 Lines 3450 3450 Branches 898 898 ======================================= Hits 3187 3187 Misses 243 243 Partials 20 20 ``` | [Files](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/598?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Ξ” | | |---|---|---| | [src/discussions/common/AuthorLabel.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/598?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2Rpc2N1c3Npb25zL2NvbW1vbi9BdXRob3JMYWJlbC5qc3g=) | `100.00% <ΓΈ> (ΓΈ)` | | | [src/discussions/common/EndorsedAlertBanner.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/598?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2Rpc2N1c3Npb25zL2NvbW1vbi9FbmRvcnNlZEFsZXJ0QmFubmVyLmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mphilbrick211 commented 9 months ago

Hi @openedx/edx-infinity! Would someone be able to review / merge this for us? Thanks!

awais-ansari commented 9 months ago

@ihor-romaniuk Please update this PR.

ihor-romaniuk commented 9 months ago

@awais-ansari PR was updated

ihor-romaniuk commented 9 months ago

@itsjeyd @sundasnoreen12 PR was updated from master branch and ready for merge

openedx-webhooks commented 9 months ago

@ihor-romaniuk πŸŽ‰ Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.