openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 61 forks source link

fix: container indents and style imports #599

Closed ihor-romaniuk closed 9 months ago

ihor-romaniuk commented 9 months ago

Description

This pull request contains:

Related Pull Requests

PR to the open-release/quince.master branch: https://github.com/openedx/frontend-app-discussions/pull/601 PR to the master branch: https://github.com/openedx/frontend-app-discussions/pull/600

Screenshots/sandbox (optional):

Before After
image image

Merge Checklist

Post-merge Checklist

openedx-webhooks commented 9 months ago

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dcb0f9e) 92.38% compared to head (dc05734) 92.40%. Report is 2 commits behind head on open-release/palm.master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/palm.master #599 +/- ## ============================================================ + Coverage 92.38% 92.40% +0.01% ============================================================ Files 163 162 -1 Lines 3297 3278 -19 Branches 890 883 -7 ============================================================ - Hits 3046 3029 -17 + Misses 232 230 -2 Partials 19 19 ``` | [Files](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [...c/discussions/discussions-home/DiscussionsHome.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2Rpc2N1c3Npb25zL2Rpc2N1c3Npb25zLWhvbWUvRGlzY3Vzc2lvbnNIb21lLmpzeA==) | `94.73% <ø> (-0.27%)` | :arrow_down: | | [src/discussions/messages.js](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2Rpc2N1c3Npb25zL21lc3NhZ2VzLmpz) | `100.00% <ø> (ø)` | | | [src/index.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2luZGV4LmpzeA==) | `0.00% <ø> (ø)` | | | [...c/discussions/discussions-home/FeedbackWrapper.jsx](https://app.codecov.io/gh/openedx/frontend-app-discussions/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2Rpc2N1c3Npb25zL2Rpc2N1c3Npb25zLWhvbWUvRmVlZGJhY2tXcmFwcGVyLmpzeA==) | `92.85% <50.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sarina commented 9 months ago

Codecov is failing because it says the non-modified file discussions/discussions-home/FeedbackWrapper.jsx was modified and is not covered. I believe this PR can be merged

openedx-webhooks commented 9 months ago

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.