fix: container indents and style imports

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.

GNU Affero General Public License v3.0

6 stars 61 forks source link

fix: container indents and style imports #600

Closed ihor-romaniuk closed 8 months ago

ihor-romaniuk commented 9 months ago

Description

This pull request contains:

a small fix for navigation container side indents and make them the same
fix paragon and brand style imports (prepending module paths with a ~ tells webpack to search through node_modules)

Related Pull Requests

PR to the open-release/palm.master branch: https://github.com/openedx/frontend-app-discussions/pull/599 PR to the open-release/quince.master branch: https://github.com/openedx/frontend-app-discussions/pull/601

Screenshots/sandbox (optional):

Before	After

Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
[ ] Is there adequate test coverage for your changes?

Post-merge Checklist

[ ] Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

openedx-webhooks commented 9 months ago

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4994de9) 92.37% compared to head (8078f6f) 92.37%. Report is 2 commits behind head on master.

:exclamation: Current head 8078f6f differs from pull request most recent head 4b9b149. Consider uploading reports for the commit 4b9b149 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #600 +/- ## ======================================= Coverage 92.37% 92.37% ======================================= Files 169 169 Lines 3450 3450 Branches 898 898 ======================================= Hits 3187 3187 Misses 243 243 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mphilbrick211 commented 9 months ago

Hi @openedx/edx-infinity! This is ready for review / merge. Thanks!

awais-ansari commented 9 months ago

@ihor-romaniuk Please update this PR.

ihor-romaniuk commented 9 months ago

@awais-ansari PR was updated

sundasnoreen12 commented 9 months ago

@ihor-romaniuk please rebase with master again

ihor-romaniuk commented 9 months ago

@awais-ansari @sundasnoreen12 rebased

openedx-webhooks commented 8 months ago

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.